search

friendly / twoway

Analysis of Two-Way Tables a la Tukey
https://friendly.github.io/twoway/
4 stars 1 forks source link

Does twoway have a method to control NA? #3

Closed SeungminHeo closed 4 years ago

SeungminHeo commented 5 years ago

Hi. I was finding nice two way plot package for median polish and I found your package 'twoway'.

I have a question whether this package can control NAs or not.

In base medpolish, I can control NAs using parameter na.rm = TRUE

Is there any guide for this?

rmheiberger commented 5 years ago

thank you for the question. we are working on adding the na.rm feature and will get back to you in a few days.

Rich

On Sun, Oct 13, 2019 at 8:55 PM SeungminHeo notifications@github.com wrote:

Hi. I was finding nice two way plot package for median polish and I found your package 'twoway'.

I have a question whether this package can control NAs or not.

In base medpolish, I can control NAs using parameter na.rm = TRUE

Is there any guide for this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

rmheiberger commented 5 years ago

Thank you for the suggestion. The devel branch of twoway on github now honors the na.rm argument. It has been tested on exactly one example, the one in demo/example-na.r Please test it on your examples and let us know how it works.

On Sun, Oct 13, 2019 at 8:55 PM SeungminHeo notifications@github.com wrote:

Hi. I was finding nice two way plot package for median polish and I found your package 'twoway'.

I have a question whether this package can control NAs or not.

In base medpolish, I can control NAs using parameter na.rm = TRUE

Is there any guide for this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/friendly/twoway/issues/3?email_source=notifications&email_token=AAP5ZI7WPMNH65DBGGANWFTQOO7QLA5CNFSM4JAJNOI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HRPFL7A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP5ZI6PDHVKJEM5CEOGDTTQOO7QLANCNFSM4JAJNOIQ .

SeungminHeo commented 4 years ago

Thank you for the suggestion. The devel branch of twoway on github now honors the na.rm argument. It has been tested on exactly one example, the one in demo/example-na.r Please test it on your examples and let us know how it works.

Thank you for your kind reponse and It is sorry that I'm late.

I cloned your devel branch, and tested with my example. It work's fine and I think It can be merged in package because this is functionality of medpolish in stat.

I have one problem with twoway package.... When I use twoway function with method = 'mean', if it contains NAs. 0 (non-NA) cases Calls occurs. What I know about function lm is it omits NAs by default and I can't guess why this happens.

Thanks you for your kind reponse and I'm looking forward to adding "Advanced Fits". If I can, I will contribute this functionality 👍

friendly commented 4 years ago

Merged into master via PR #4