friendlyanon / GelbooruEnhancement

Image Viewer and Endless Scroll userscripts for Gelbooru and various other boorus
Do What The F*ck You Want To Public License
56 stars 7 forks source link

Gelbooru image viewer doesn't work anymore #19

Open Tamaniha opened 4 years ago

Tamaniha commented 4 years ago

The script stopped working on Gelbooru for about a week now. It still works on rule34 so something must've changed on Gelbooru.

Tamaniha commented 4 years ago

It's definitely broken on gelbooru because it still works on other sites. Not sure what changed. image

Tamaniha commented 4 years ago

Please fix this great script!

DimensioX1 commented 4 years ago

Same problem here, works fine on every other site but stopped working on gelbooru the other day

Tamaniha commented 4 years ago

I really hope this gets fixed. I think fixing it is easy for a pro. I tried to fix it but failed due to my limited knowledge in javascript.

Tamaniha commented 4 years ago

Thanks! What @wexavier did fixed the gallery view but it's not loading the images properly for some reason and this keeps popping up whenever an image is clicked.

Untitled
wexavier commented 4 years ago

@Tamaniha Strange, it's working fine for me... When you click on any image for the first time you should get a window asking for permission to cross-origin resources like this: Annotation 2020-08-21 144838 Make sure you click on "always allow domain". I did't add a @connect tag for this domain because it seems to interfere with the progress bar functionality (it just stops working but the image will still be loaded properly). If you ended up blacklisting it, you can revert that in the settings under the XHR Security section. And if the domain is whitelisted and you're still getting this error please post the error message(s) you are getting in the console.

Tamaniha commented 4 years ago

I did that and tried reinstalling the script but the permission window didn't pop up again for some reason so I tried clearing the cookies and that fixed it and I got the window asking for permission. Many thanks!

@friendlyanon please approve this pull request!

Tamaniha commented 3 years ago

It stopped working again but I'm not getting any errors in the console this time

DimensioX1 commented 3 years ago

same

Tamaniha commented 3 years ago

we need your help @wexavier

Tamaniha commented 3 years ago

@wexavier Thank you very much There's an issue because it works sometimes and doesn't work for most of the time when I click on an image on the same page. I have no clue how to reproduce the actions that make it work but usually when the page opens and I click on an image the first time it doesn't work but then I click go back and press page up/page down and try again on another image until it works. And when It starts to work on the page it also works on the image I clicked on the first time. No Idea what is causing this and I've tried it on chrome and firefox and got the same result

wexavier commented 3 years ago

This did happen a few times for me as well, but it's not that common. Without a console error or a way to reproduce the bug it's hard to pinpoint the part of the code causing it.

Tamaniha commented 3 years ago

My way to get around it now is to keep hard reloading the page until it works which it does most of the time

Tamaniha commented 2 years ago

@wexavier It's not working correctly again and sometimes works but only for the last 10 images or so. Are you having this issue too?