search

friendlyanon / cmake-init

The missing CMake project initializer
GNU General Public License v3.0
2.03k stars 78 forks source link

Windows SDK requirement #7

Closed friendlyanon closed 11 months ago

friendlyanon commented 3 years ago

Some Windows SDKs (10.0.17763.0 and earlier?) have bugs in them that emit warnings with the new, standards conforming preprocessor (/Zc:preprocessor). The SDK can be specified by setting the system version for CMake (as is done in a6683d5), but this has potential issues.

Windows developers using this script locally will also have to install a Windows Update newer than 10.0.17763 with the matching Windows SDK to get the correct behavior by default.

This might be too much of a mental overhead for someone just starting out. Should the preprocessor flag be dropped and instead the ubuntu and macos CI runs be used to verify the conformance of the code?

friendlyanon commented 3 years ago

I have decided to remove /Zc:preprocessor with 11d35cd to keep things simple. Once the windows-2022 github image is released as the latest one, this could be added back.

friendlyanon commented 2 years ago

Once #35 goes through, this can be closed as well.

friendlyanon commented 11 months ago

35 has been closed for a while, so this is not relevant anymore.