search

friendo9876 / MI-449-SS17-740-html-meta-elements-_f2DoK

0 stars 0 forks source link

Project Feedback #1

Open friendo9876 opened 7 years ago

friendo9876 commented 7 years ago

@KatieMFritz Can you take a look at this? It's hosted here and meets the following criteria:

KatieMFritz commented 7 years ago

Hi Mateen, this is a very fine-looking T-Shirt Emporium! 👕 👍

Valid HTML

The W3 Validator is freaking out a little because you're missing <!DOCTYPE html> at the beginning of your files. 🙂 Can you fix that and then resolve any HTML errors that remain?

Location

I see geo.position, but not ICBM. From the lesson:

Even though they'll provide the same information, it's good to include both of these elements, because some services might look for one, but not the other.

Unique title & description for each page

Here are some guildeines for writing titles and descriptions for your pages (including title and meta name="description elements, Twitter metadata, and Facebook (og) metadata:

  1. Each page should have a unique title and description that describes that specific page for people who have no idea what your site is about (because they will see this info on social media or search results before they ever come to your site). From the lesson:

    [It's] common for homepages to describe the entire website. On every other page however, this information should be specific to the current page.

✔️ Great job with this - the titles & descriptions make it clear that the pages are different.

  1. Each page should (usually) have consistent titles and descriptions across platforms, i.e. the Twitter, Open Graph, and general titles and descriptions should all match each other. This helps users figure out whether they've already visited that page. It also makes life easier for you - you can just copy and paste! Once you get into more advanced site development, you can use the same variables across all three places.

❗️ I recommend using your Twitter titles and descriptions, in this case. I think they're the most engaging and clear.

  1. Titles and descriptions should be brief. Different platforms display different amounts of text, but I usually use 50-70 characters for titles, 100-150 characters for descriptions. Anything longer will likely get cut off.

✔️ This is great.

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! :rocket:

friendo9876 commented 7 years ago

I think I fixed it all, please check again

KatieMFritz commented 7 years ago

Nice job fixing the html and location stuff! 🐶

I'm still looking for this:

  1. Each page should (usually) have consistent titles and descriptions across platforms, i.e. the Twitter, Open Graph, and general titles and descriptions should all match each other. This helps users figure out whether they've already visited that page. It also makes life easier for you - you can just copy and paste! Once you get into more advanced site development, you can use the same variables across all three places.

❗️ I recommend using your Twitter titles and descriptions, in this case. I think they're the most engaging and clear.

If you're not sure what I mean, let me know on Slack and I can explain it differently!

KatieMFritz commented 7 years ago

@friendo9876 Just pinging you on this one - it's an easy win. :)

friendo9876 commented 7 years ago

fixed it. Now all the descriptions and titles match

KatieMFritz commented 7 years ago

Wooooooo! 🎉 🎈 🌟 :shipit: