search

friends-of-contao / contao-memberlist

Memberlist extension
6 stars 10 forks source link

Possible 4.8 Flow for this module #23

Open Sioweb opened 4 years ago

Sioweb commented 4 years ago

Hi there,

i've updated this module fo me, local and maybe u want to use it too, for contao 4.8 and newer - and maybe with a new major version.

The only real change from me is, Foc\Memberlist\Controller\FrontendModule\Memberlist line 198 - it will check related fields and return the related models.

Sioweb commented 4 years ago

I dont get it, why someone added login = 1 to this function: https://github.com/friends-of-contao/contao-memberlist/pull/23/commits/0b9f42c0710d26136bcea4f580b3188e4c25577f#diff-af8bcd88e358acfd9be4d37bc80a10b0

Maybe its required for something, but it wont working with detailpages, if user has no permission to login.

fritzmg commented 4 years ago

@Sioweb could you update this PR please? It also seems to contain a lot of unrelated changes.

Sioweb commented 4 years ago

I dont get it, what exactly do u need?

What to update? What do u mean unrelated?

fritzmg commented 4 years ago

What do u mean unrelated?

For example your PR contains changes to the formatting of the composer.json (including invalid UTF-8 characters).

Also it is not quite clear to me what your PR actually does. Is it just a refactoring of the existing code into a contao-bundle structure?