search

friends-of-forkcms / fork-cms-module-commerce

Commerce module allows you to manage a product catalog and create a unique webshop using Fork CMS. WORK IN PROGRESS!
MIT License
6 stars 7 forks source link

Profile activation key required when continuing without an account #38

Open alessandrocraeye opened 2 years ago

alessandrocraeye commented 2 years ago

In the checkout flow, if you choose to continue without an account (and don't provide a password on the address step) a commerce account is created (without a profile_id) when going to the next step. This triggers the AccountCreated event listener which requests the profile activation key (linked below) for the activation e-mail, this fails without profile_id and throws an error.

https://github.com/friends-of-forkcms/fork-cms-module-commerce/blob/ca195b538ba453c9c18796b10dad0bfed376217f/src/Backend/Modules/Commerce/Domain/Account/EventListener/AccountCreated.php#L29

jessedobbelaere commented 2 years ago

Hi Alessandro, it's been a few months since I continued on this module, it's still very much work in progress and haven't been used in a project (e.g. no payment modules written yet) 😅 Great find. I'll take this issue into account when I continue, or feel free to contribute fixes if you plan to use this module. I'll set up semver releases when it's becoming a more stable module.