friends-of-freeswitch / switchio

asyncio powered FreeSWITCH cluster control
http://switchio.rtfd.io
Mozilla Public License 2.0
191 stars 28 forks source link

Don't use per connection loggers? #57

Open goodboy opened 6 years ago

goodboy commented 6 years ago

The logging cookbook has a good snippet on using the extra keyword to add contextual info to output. It also suggests not using Logger instances per connection like we do.

It means changing a lot of log message calls for maybe minimal benefit unless we use a LogAdapter. I'm split on what to do since generally there's only one connection / event loop per FS process in switchio and maybe it's not worth the effort?