search

friends-of-freeswitch / switchio

asyncio powered FreeSWITCH cluster control
http://switchio.rtfd.io
Mozilla Public License 2.0
191 stars 28 forks source link

Remove `subscribe` attribute from `Router` constructor in doc (Readme) #77

Open Azharsayyed5 opened 3 years ago

Azharsayyed5 commented 3 years ago

Hi,

Please remove the subscribe attribute getting below error.

Traceback (most recent call last):  File "/home/vivaconnect/backup_old/project/vb/fs_workers/python_files/InboundServer.py", line 3, in    router = Router( TypeError: init() got an unexpected keyword argument 'subscribe'

goodboy commented 3 years ago

Hey @Azharsayyed5.

Sorry I'm not totally sure i understand the problem.

subscribe does seem to be defined correctly in Router.__init__().

Maybe you can clarify your error a little better?

goodboy commented 3 years ago

Only thing I can think of is something going weird in extend_attr_list() on init.

Azharsayyed5 commented 3 years ago

@goodboy

Sure, The readme file still has the 'subscribe' attribute for Router class of inbound server and as i was Implementing the inbound server while I saw the subscribe attribute in readme and missing in official document.

Initially I took the reference of readme file for inbound server, that's why i got above error.

router = Router( guards={ 'Call-Direction': 'inbound', 'variable_sofia_profile': 'external'}, subscribe=('PLAYBACK_START', 'PLAYBACK_STOP'), )

Hope you understand.

goodboy commented 3 years ago

@Azharsayyed5 I still am unclear what you mean.

If the subscribe kwarg was causing a problem then this test would fail in CI, but it clearly is not.