search

friends-of-presta / fop_console

Prestashop Module providing a set of shell/terminal commands for developers (PrestaShop 1.7.5+)
Academic Free License v3.0
85 stars 35 forks source link

start using phpstan really #127

Closed SebSept closed 3 years ago

SebSept commented 3 years ago

currently phpstan is at level 0. that's useless. I suggest to start at level 4, that pretty simple to fix, and a simple (weak) base.

At the moment I introduced phpstan, I configured it at level 0 to avoid annoyance with existing problem. I was unaware of the --baseline option (I did not found what it was for). The baseline make us able to run phpstan at any level and ignore existing issues detected. So we can start using it at any level without having to fix all existing errors.

So all new PR will have to pass at the level.

I suggest 4 for a first start...

ghost commented 3 years ago

level : 5️⃣ passe pour moi , donc 4️⃣ oui c'est un début !