search

friends-of-presta / fop_console

Prestashop Module providing a set of shell/terminal commands for developers (PrestaShop 1.7.5+)
Academic Free License v3.0
84 stars 35 forks source link

62 validate hook name #162

Closed nenes25 closed 2 years ago

nenes25 commented 3 years ago

Improve issue #62 by falling creating a new hook if it's name is invalid or start with hook image

nenes25 commented 2 years ago

Thanks for the feedback. So some changes are still needed. I'll check and ask for a new validation after :smile:

SebSept commented 2 years ago

I pushed some commits right now, but I can't see them ...

SebSept commented 2 years ago

I've made a PR for my requested changes @nenes25 , can you review / merge them ? https://github.com/nenes25/fop_console/pull/2

nenes25 commented 2 years ago

Thanks your code is good :) I've merged the code and push to the branch. So i'll merge it also :)