friends-of-presta / fop_console

Prestashop Module providing a set of shell/terminal commands for developers (PrestaShop 1.7.5+)
Academic Free License v3.0
85 stars 36 forks source link

Version command #169

Closed SebSept closed 3 years ago

SebSept commented 3 years ago

display the fop console version. To check that the version is up to date. asciicast

ghost commented 3 years ago

It's work well, for the last u can use https://api.github.com/repos/friends-of-presta/fop_console/releases

SebSept commented 3 years ago

Seems great to me!

Just to be sure, registered version = database version and disk version = files version ?

That's it, maybe it's not so clear, I'll try some improvement.

Adding last released version and colors (red when version is not the last for local ones, green for the opposite) would be a plus but as it is, I approve!

good idea. I'll do it.

SebSept commented 3 years ago

It's work well, for the last u can use https://api.github.com/repos/friends-of-presta/fop_console/releases

Thanks for the tip. I'll implement this too.

ghost commented 3 years ago

Hey @SebSept we merge or we wait green and red ?

I see it's in draft ?

SebSept commented 3 years ago

I have no idea for a better wording, so the last point before merging is the command name.

It must follow 'fop:domain: action' . Any idea ?

tom-combet commented 3 years ago

fop:about:version should be great imo! Not a real domain, but I don't think there is a real one for this command... or maybe Environment (looks like it will be the catch-all domain haha)?

(Btw I think @okom3pom was talking about colors formatting?)

SebSept commented 3 years ago

ready to merge now.

asciicast

SebSept commented 3 years ago

sorry @okom3pom , I missed you message.

Hey @SebSept we merge or we wait green and red ?

what do you mean ? it's about text formating ?

ghost commented 3 years ago

I was referring to: https://github.com/friends-of-presta/fop_console/pull/169#pullrequestreview-773543074

But i don't found the way to color in a table

It's ok for me