Fix code quality tools

[tom-combet]

Fixes #150 (and closes #203?).

Fixed issues: • PHP-CS-Fixer workflow step wasn't using our custom configuration file. • PHPStan was old... very old... • GrumPHP was overwriting our level setting and checking dot files (where PHPStan doesn't).

[nenes25]

Good job :+1: ! Do we need to check an other thing than that the automatic workflows are good ?

[SebSept]

I think we need to test on our machines.. I'd like to do it.

[tom-combet]

Yes, every reviewer should check on his side if GrumPHP works fine by running composer fop_check. You should have an "All Good" output.

[SebSept]

I will also make a commit in my ide

[tom-combet]

So you reported than grumphp overrides the default level, good catch. Maybe we can add a note in phpstan.neon about that. (and also in grumphp).

I already wrote a comment in grumphp configuration file. As it concerns only GrumPHP execution, I don't think it's necessary to add a note in phpstan configuration. Did you mean add a comment there too or did I misunderstand?

And that .dotfiles option also need to be specified.

Same here.

[SebSept]

I already wrote a comment in grumphp configuration file. As it concerns only GrumPHP execution, I don't think it's necessary to add a note in phpstan configuration. Did you mean add a comment there too or did I misunderstand?

Yes, that's what I mean. Someone may change the value in in phpstan.neon.dist then run fop_check or commit.

[tom-combet]

Ah ok I see, I'll add this 👍

[SebSept]

can anyone else confirm it's ok with their config ? @nenes25, @okom3pom, @jf-viguier

[SebSept]

I've just re tested, work fine both on command line and inside phpstorm :)

[SebSept]

can anyone else confirm it's ok with their config ? @nenes25, @okom3pom, @jf-viguier

ping

[SebSept]

You "just" need to resolve the conflicts @tom-combet .

[tom-combet]

@SebSept Done, thanks for validating it!