New command to scaffold a module: fop:module:generate

[luigimassa]

This command scaffold new module.

Command

• fop:generate:module

Arguments

• <module name>: your module name to generate
• <name space>: the namespace of the module

[jf-viguier]

Thanks @luigimassa for your PR ! Nice work. We have a naming convention, the command should be fop:module:generate instead of fop:generate:module

The convention is fop:domain:command

[jf-viguier]

Is there a way to launch php-cs-fixer to .php.twig files ? There are some little fix (spaces, ...) to apply I guess

[luigimassa]

re are some little fix (spaces, ...) to apply

Ok, i fix it

[SebSept]

run vendor/bin/php-cs-fixer fix ./ add and commit the file and you're done (probably).

---

If it's not ok,

You can run vendor/bin/php-cs-fixer fix --dry-run -q ./ || echo 'nop :( if "nop :(" is printed, the file is not fixed.

vendor/bin/php-cs-fixer fix --dry-run --diff . shows the diff.

Just in case, because your vendor directory is maybe not right, delete it and run composer install

[luigimassa]

run vendor/bin/php-cs-fixer fix ./ add and commit the file and you're done (probably).

If it's not ok,

You can run vendor/bin/php-cs-fixer fix --dry-run -q ./ || echo 'nop :( if "nop :(" is printed, the file is not fixed.

vendor/bin/php-cs-fixer fix --dry-run --diff . shows the diff.

Just in case, because your vendor directory is maybe not right, delete it and run composer install

done

[luigimassa]

Yeah! :D

[nenes25]

Great the tests are now ok ! Let's dive into the command behaviors tests now :smile: Thanks @luigimassa for your work :+1: !

[SebSept]

all tests are green 👍🏼 Is it ok to merge @nenes25 & @Kaudaj or do you think some things are mandatory before merging ?

The command may run without user interaction. I think this point should be resolved : "Check if it's a new module or not without asking the user (very easy with a simple file_get_exists)." point is mando

[tom-combet]

@SebSept Already resolved: https://github.com/friends-of-presta/fop_console/pull/239/commits/a5978415e8b45eaa2c8ad9f518e2631a4a210364 😉

Some of my requests haven't been resolved but they were not critical. Maybe the // TODO: Edit comments could be harmonized, it looks quite messy right now (there are 'xxxxxx' values, '????' values, // edit comment...).

[SebSept]

@SebSept Already resolved: a597841 wink

Some of my requests haven't been resolved but they were not critical. Maybe the // TODO: Edit could be harmonized, it looks quite messy right now (there are 'xxxxxx' values, '????' values, // edit comment...).

@luigimassa will fix this or do you prefer that the merge in the current state ?

[luigimassa]

please wait.... I do finish a big activity.

[jf-viguier]

thanks @luigimassa for your geat work,

[tom-combet]

No need to rush: quality > quickness!

[luigimassa]

Please can you merge?

[tom-combet]

@luigimassa Hi, please check the changes I requested 😉

[SebSept]

changes requested by @tom-combet are satisfied. I guess changes requested by @nenes25 are also satisfied.

I generated a module, there is no php errors, I think everything is alright...

[SebSept]

Is it ok for you @nenes25 ?

[nenes25]

A huge thanks for this great job @luigimassa , well done !

[luigimassa]

Thank you guys!