friends-of-presta / fop_console

Prestashop Module providing a set of shell/terminal commands for developers (PrestaShop 1.7.5+)
Academic Free License v3.0
84 stars 35 forks source link

Synchronise about:version command to last Prestashop version. #250

Closed MeKeyCool closed 2 years ago

MeKeyCool commented 2 years ago

Take a look at https://github.com/PrestaShop/PrestaShop/pull/27632, ModuleRepositoryInterface as been moved

nenes25 commented 2 years ago

Hi @MeKeyCool,

Thanks for your PR :smile: the fix you suggest is related with the improvements done in Prestashop 8 i guess ?

As we want to keep this tool compatible with not only the lastest version of Prestashop, i think we should use a way where we can manage both v8 and other version.

ping @SebSept @jf-viguier WDYT ?

MeKeyCool commented 2 years ago

Hi @MeKeyCool,

Thanks for your PR smile the fix you suggest is related with the improvements done in Prestashop 8 i guess ?

As we want to keep this tool compatible with not only the lastest version of Prestashop, i think we should use a way where we can manage both v8 and other version.

ping @SebSept @jf-viguier WDYT ?

Yes, this change is related to a breaking change in Prestashop v8. On my develop branch, I can't run fop:about:version command.

:thinking: As it is only a check, I think I can make something that work for both version ...

I'll try tomorrow ;)

SebSept commented 2 years ago

At the moment, we havn't decide to change the minimal support version. We must start to think about it (open a discussion can be good).

I have a plan to make a command that displays information about a module, I guess I'll write a custom dataprovider for the purpose. So we can use that dataprovider for the current command.

SebSept commented 2 years ago

For the moment, we can can use something more simple that will support both v8 and 1.7.5

By the way, can't we use services ? It will be easy to check if a service is defined or not.

MeKeyCool commented 2 years ago

@SebSept , was your change request about the type check ?

SebSept commented 2 years ago

@SebSept , was your change request about the type check ? I can't remember. No matter. I works fines in my tests. Thanks for your patience.

SebSept commented 2 years ago

Thanks @MeKeyCool 😎