Closed MeKeyCool closed 2 years ago
Hi @MeKeyCool,
Thanks for your PR :smile: the fix you suggest is related with the improvements done in Prestashop 8 i guess ?
As we want to keep this tool compatible with not only the lastest version of Prestashop, i think we should use a way where we can manage both v8 and other version.
ping @SebSept @jf-viguier WDYT ?
Hi @MeKeyCool,
Thanks for your PR smile the fix you suggest is related with the improvements done in Prestashop 8 i guess ?
As we want to keep this tool compatible with not only the lastest version of Prestashop, i think we should use a way where we can manage both v8 and other version.
ping @SebSept @jf-viguier WDYT ?
Yes, this change is related to a breaking change in Prestashop v8.
On my develop branch, I can't run fop:about:version
command.
:thinking: As it is only a check, I think I can make something that work for both version ...
I'll try tomorrow ;)
At the moment, we havn't decide to change the minimal support version. We must start to think about it (open a discussion can be good).
I have a plan to make a command that displays information about a module, I guess I'll write a custom dataprovider for the purpose. So we can use that dataprovider for the current command.
For the moment, we can can use something more simple that will support both v8 and 1.7.5
By the way, can't we use services ? It will be easy to check if a service is defined or not.
@SebSept , was your change request about the type check ?
@SebSept , was your change request about the type check ? I can't remember. No matter. I works fines in my tests. Thanks for your patience.
Thanks @MeKeyCool 😎
Take a look at https://github.com/PrestaShop/PrestaShop/pull/27632,
ModuleRepositoryInterface
as been moved