Use reactphp/async instead of clue/reactphp-block

friends-of-reactphp / mysql

Async MySQL database client for ReactPHP.

MIT License

334 stars 66 forks source link

Use reactphp/async instead of clue/reactphp-block #163

Closed dinooo13 closed 2 years ago

dinooo13 commented 2 years ago

See https://github.com/reactphp/async

Ref: https://github.com/clue/reactphp-block/pull/67, https://github.com/clue/reactphp-block/issues/68, https://github.com/reactphp/http/pull/464 and https://github.com/clue/reactphp-mq/pull/34

dinooo13 commented 2 years ago

Still need to test this, no mysql:5 on arm.

dinooo13 commented 2 years ago

Locally with PHP 8.1 this works fine for me. Can we restart the checks? Some weird failing there with 8.1, 8, 7.3 and HHVM green and only 7.1 failing.

dinooo13 commented 2 years ago

Resolved, thanks for the review 👍🏼

dinooo13 commented 2 years ago

I think something is a bit flaky in the tests on the ci, should we maybe open an issue further investigating this?