This simple changeset adds proper Promise v3 template types to describe API arguments and return values. The change is pretty straightforward, as most of the work was done upstream and in previous PRs linked below.
Note that this project doesn't currently use PHPStan itself, so this is a bit harder to reproduce on its own. I've tested this in a number of downstream projects and it appears this is the minimal changeset required to make downstream projects work that depend on these functions. I'll link relevant PRs against this one for reference.
I'd vote to get this in as is for now to make sure we unblock any downstream projects. Note that this doesn't preclude how and/or whether we're going to integrate PHPStan into pre-v3 components like this one as already discussed in reactphp/async#77.
This simple changeset adds proper Promise v3 template types to describe API arguments and return values. The change is pretty straightforward, as most of the work was done upstream and in previous PRs linked below.
Note that this project doesn't currently use PHPStan itself, so this is a bit harder to reproduce on its own. I've tested this in a number of downstream projects and it appears this is the minimal changeset required to make downstream projects work that depend on these functions. I'll link relevant PRs against this one for reference.
I'd vote to get this in as is for now to make sure we unblock any downstream projects. Note that this doesn't preclude how and/or whether we're going to integrate PHPStan into pre-v3 components like this one as already discussed in reactphp/async#77.
Builds on top of reactphp/promise#247 and #157