friends-of-reactphp / mysql

Async MySQL database client for ReactPHP.
MIT License
331 stars 66 forks source link

Rename `QueryResult` to `MysqlResult` #187

Closed SimonFrings closed 8 months ago

SimonFrings commented 8 months ago

In this pull request, I propose changing the current QueryResult to MysqlResult. This change aligns with the recently introduced MysqlClient from #186, ensuring a consistent "Mysql" prefix throughout.

The name "QueryResult" is not incorrect in this case. However, when working with multiple database clients in one project, it can lead to confusion about which specific "query result" is being referred to. For instance, the https://github.com/clue/reactphp-sqlite project has a similar class named Result, which should also be renamed to something like SqliteResult in the future.

Furthermore, we applied a similar reasoning in https://github.com/reactphp/socket/pull/263 and https://github.com/reactphp/http/pull/417.

Refs #147 Builds on top of #186