search

friends-of-reactphp / stomp

STOMP bindings for ReactPHP.
MIT License
115 stars 42 forks source link

Capture and emit input end event #38

Closed jasonrsmith closed 7 years ago

jasonrsmith commented 9 years ago

This is another PR for reactphp/stomp#24. It forwards the end event through the InputStream class and through the Client, similar to how errors are handled.

I need to handle server-side restarts, and I can't detect a disconnection without this fix.

Thank you!

Jason

clue commented 9 years ago

There's ongoing discussion about whether it makes sense to completely drop the end event here: https://github.com/reactphp/stream/pull/21

As such, I would suggest updating this PR to use the close event instead (which also appears to be more semantically correct here).

Otherwise LGTM :+1:

Thanks for your contribution! :)

jasonrsmith commented 9 years ago

@clue , Sounds good. I updated to use "close" instead".

Thanks!

Jason

clue commented 9 years ago

Thanks for the quick update! LGTM :+1:

Easen commented 8 years ago

+1

brettmc commented 7 years ago

is anybody still around that could merge this very useful pull request? It does exactly what I need to be able to tell when my server connection dies so that I can take action accordingly.

davidkmenta commented 7 years ago

Hi guys!

What about this PR? Will be merged? :)

WyriHaximus commented 7 years ago

Thanks, will look into tagging a new release later today :+1: