Heartbeat implementation

[RolfBabijn]

I'm curious about something. While looking at the network of this repository I've come across the branch of @capablue. They implemented the heartbeat functionality I was looking for and they apparently think it is stable enough because they've added a tag. After some testing locally this does suit our needs.

What I find most interesting is that I can't find any pull request or issues created by Capablue in this repository. Unfortunately the organisation doesn't have any public members so I'm unable to search more in depth and contact people. Is this something worth looking into? Perhaps even forking that repository and create a pull request myself?

I would like to continue to use the official stomp repository instead of a fork. Any thoughts, @igorw?

Link to repository: https://github.com/capablue/stomp

[kevinmlong]

@Gadgetdude - Any luck on this? Also - were you ever able to include the capablue version via composer? I keep getting the following error:

Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package capablue/stomp could not be found in any version, there may be a typo in the package name.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

I'm at a point where I would like to look into heartbeats. Thanks!

[kevinmlong]

@Gadgetdude - I was able to figure out how to do it. Haven't included a fork through composer before. Was able to accomplish it using this:

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/capablue/stomp.git"
        }
    ],
    "require": {
        ...
        "react/stomp": "0.3.1",
        ...
    }

As for not having to use (an unmaintained) fork - @igorw @cboden @romainneutron @WyriHaximus - what's the plan for pulling in the necessary stuff for the heartbeat and disconnect features that have been added? Are y'all still maintaining this repository?

[phiamo]

any chance somebody still has a copy of that fork ?

[RolfBabijn]

I think it got moved at some point to another repository. The last commit to this repository is also from Capablue concerning the heartbeat. You can find it here: https://github.com/blex18/stomp