Upgrade `react/socket` to ^1.1

friends-of-reactphp / stomp

STOMP bindings for ReactPHP.

MIT License

115 stars 42 forks source link

Upgrade `react/socket` to ^1.1 #51

Open adrianb93 opened 5 years ago

adrianb93 commented 5 years ago

I had a dependency clash for react/socket ^1.1.

That version has all classes set as final, so I had to put a bit of effort to learn react/socket and get this package working with it. Hopefully, you're happy with the upgrade. Otherwise, I am open to feedback to get this merged.

Notes:

I don't think this is a breaking change. I didn't need to update the functional tests.
I added a connection-status event. It was useful information for me to print in my logs.

adrianb93 commented 5 years ago

I've made my changes compatible with PHP 5.6
I've made the composer.lock compatible with PHP 5.6.
I don't think the failed ActiveMQ builds are due to my changes.