search

friendsofagape / autographa-mt

A scripture machine translation system.
https://autographamt.com/
GNU General Public License v3.0
1 stars 8 forks source link

AgMT-Assign Books -Email notification is sent to a user even if no books are assigned #128

Open AnnCherianA opened 3 years ago

AnnCherianA commented 3 years ago

Issue Description: In the 'assign books' tab even if books are not selected for assignment, email notification is incorrectly sent to the user informing of work assignment. AgMT- Email notification sent to user even if books are not selected for assignment

Steps: Login as Admin Select Create/Assign projects Select a language combination such as English -> Aari Select assign users In the users list page, select the book tab . When the list of books are displayed, do not select any book Click Assign
Observation: Without selecting any books for assignment along with the alert message saying user role updated , an email notification is sent to the user saying Books assigned in the selected project. Expected Result: The email notification should be sent only if there are books assigned or there is any change such as book unassigned .

AnnCherianA commented 3 years ago

@Savithamark please test this issue and share the results.

savithasusannamark commented 3 years ago

If user does not select any books and click on assign,email is sent to the user that " books are assigned", and even if the assined books are unselected and click on assign, it is sending the same email that " books are assigned": @Savithamark Screenshot not required at this point ,since the focus is on basic QA.

AnnCherianA commented 3 years ago

@Savithamark please move to next step

savithasusannamark commented 3 years ago

Issue can be moved to "New Issues"

AnnCherianA commented 3 years ago

@Savithamark ,as per testing process , it is not supposed to move to New Issues.

savithasusannamark commented 3 years ago

Issue can be moved to In progress

AnnCherianA commented 3 years ago

Logged in as admin. In Create/assign projects tab, cleared the assigned books and the below error was observed image Expected : If assigned books are unchecked(unassigned), then the alert should be such that the user is updated clearly such as 'Books unassigned'

AnnCherianA commented 3 years ago

On assigning a new book , the alert /error message is again misleading. Assigned books and found incorrect alert

AnnCherianA commented 3 years ago

Tested the following cases