Invalid file formats other than usfm ends in looping

friendsofagape / autographa-mt

A scripture machine translation system.

https://autographamt.com/

GNU General Public License v3.0

1 stars 8 forks source link

Invalid file formats other than usfm ends in looping #144

Open AnnCherianA opened 3 years ago

AnnCherianA commented 3 years ago

Issue : Desc : If any file of invalid format is uploaded using Add File button in the Upload sources page it displays a continuous loop . An accurate error message informing the user of the error in file format and to close the button is to be displayed

Expected : The looping is to be handled and an alert is to be displayed informing the user to upload a valid file format.

jincypjose commented 3 years ago

Issue solved now while clicking on ADD FILES button we only get usfm, sfm file if there.And in case if the usfm files are not proper it will get displayed on window above Screenshot from 2021-08-13 15-01-34 and doesn't get add on to the files for upload (i.e only proper usfm file will get uploaded) and there is no infite loop

AnnCherianA commented 3 years ago

@jincypjose please share usfm file for testing.

jincypjose commented 3 years ago

Have shared usfm file with QA team for testing

savithasusannamark commented 3 years ago

below are the obseravtion made: when we upload the first file we are getting the below message error_uploadfile .

and for the second usfm file we are getting sever side errorr, when we click on ok button is says bible upload failed. source_uplaod

when we upload the different file type other than usfm we are getting the below message:

issue_144

AnnCherianA commented 3 years ago

@Savithamark please find the review comments below -when you mention words such as first file, second file, how will the other participants of this thread understand ? Only one usfm file was shared for testing, please share the test result for that -Test result is not clear from the description ,whether the test has passed or not.

AnnCherianA commented 3 years ago

@Savithamark please work on the comments so that the issue can be moved soon. We are waiting for your updated comment to move the issue

Savithamark commented 3 years ago

I have tested with the two usfm file. for the file which which was shared for testing(2nd screenshot), when we click on add file the file is getting added, but upload is not successfull, its is giving server error. So still issue there.

and for the other usfm file the file is not getting added(1st screenshot), and when we click on upload, it is giving the usfm parsing error.

AnnCherianA commented 3 years ago

@Savithamark where should the issue move

Savithamark commented 3 years ago

issue can be moved to In progress

jincypjose commented 3 years ago

As discussed, since the original issue of invalid format looping is resolved moving to QA.

Savithamark commented 3 years ago

@AnnCherianA invalid file format does not ends in infinite looping, test result is passed, so the issue can be moved to done

AnnCherianA commented 3 years ago

@Savithamark please access zenhub and move the issue to Done.

AnnCherianA commented 3 years ago

@Savithamark Also, create a separate issue for the error seen when usfm file is uploaded and assign to me and Bobby.

Savithamark commented 3 years ago

@AnnCherianA ok creating a seperate issue for usfm file upload. once I get zenhub access, I will move this issue to done

Savithamark commented 3 years ago

Issue is moved to done