search

friendsofgo / killgrave

Simple way to generate mock servers written in Go
https://friendsofgo.github.io/killgrave/
MIT License
523 stars 100 forks source link

chore: check coverage at PR time #168

Open kilianc opened 6 months ago

joanlopez commented 6 months ago

Hey @kilianc,

Thanks for your contribution, I see you're trying to expand the use of your new project 😉 However, although I see how cool the tool is, I'm not really sure that we actually want to add such a detailed HTML view for coverage changes, as I feel like a simple comment in the PR would be more than enough.

Even in such case, I guess any widely used, free-to-use service for open-source projects like Codecov or Coveralls would probably be a better candidate, with all respects.

So, I'm not definitely rejecting it, but let's put it on hold, meanwhile I'll try to discuss it with @aperezg in order to move one with a formal and final decision.

That said, thanks anyway for bringing your proposals and for your contributions to this project! 🙌🏻

kilianc commented 6 months ago

No offense taken! And please share any more feedback if don't find it useful.