search

friesofdoom / FriesBSCam

Beat saber camera for Liv made by fries
17 stars 0 forks source link

Cleaned up websocket interface. Removed AssemblyInfo and moved versio… #17

Closed benaclejames closed 2 years ago

benaclejames commented 3 years ago

Cleaned up Websocket Interface. Moved assembly headers to MyCameraPlugin.cs. Moved main types to correct namespace. Fixed some fields and methods being declared as public, even though they're only used in the same class. Moved default settings txt info to an embedded resource for organisation. Enforced correct naming scheme for public, private, static, const and readonly fields.

friesofdoom commented 3 years ago

Wow, this looks pretty awesome (apart from GitHub completely butchering the diffs). Thank you! I'll pull the code and test it locally sometime today.

benaclejames commented 3 years ago

Aha, Thanks! 😄 Just a heads up, I didn't test the http plugin integration very thoroughly but, logically speaking, there's no reason why it wouldn't work. Though like all code, it'll probably find a way to break so apologies if that's the case!

friesofdoom commented 3 years ago

Unfortunately there does seem to be a new bug in your changes, I just haven't had enough free time to sit down and figure out what the problem is. As soon as I do I should be able to merge the PR.

benaclejames commented 3 years ago

Oh, what's the bug?