frigaut / yao

An adaptive optics simulation package. Yao is a yorick plugin. Many of the core routines are written in C, which makes it very fast.
http://frigaut.github.io/yao/index.html
GNU General Public License v2.0
22 stars 7 forks source link

pl_get_color error #13

Open UlasGokay opened 6 years ago

UlasGokay commented 6 years ago

Dear all, i am running the script file "yao_loop_example.i" for trying gsmag and gainv for a SH WFS, i am receiving an error: "(pl_get_color) LHS of assignment not an l-value (scalar double, long, int?)" which directs me to LINE: 1240 FILE: /usr/lib/yorick/i/plot.i but i couldn't solve the problem, i am guessing this is an issue related to this part of the code: "plg,strehlarray(ll,),gainv,color=-ll-4;", can you help? Best regards Ulas

frigaut commented 6 years ago

Hi Ulas,

What version of yorick and of yao are you running? Thanks, Francois

On 28 Dec 2017, at 7:07 pm, UlasGokay notifications@github.com wrote:

Dear all, i am running the script file "yao_loop_example.i" for trying gsmag and gainv for a SH WFS, i am receiving an error: "(pl_get_color) LHS of assignment not an l-value (scalar double, long, int?)" which directs me to LINE: 1240 FILE: /usr/lib/yorick/i/plot.i but i couldn't solve the problem, i am guessing this is an issue related to this part of the code: "plg,strehlarray(ll,),gainv,color=-ll-4;", can you help? Best regards Ulas

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/frigaut/yao/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlb4q9w1nB6MdUMzzPrRjiYMwd4odiGks5tE0xRgaJpZM4ROGlj.

UlasGokay commented 6 years ago

Hi Francois, i am running yao 5.4.0 on yorick 2.2.04, many thanks, Ulas

mvandam commented 6 years ago

Hello!

I also reproduce this bug. The problem is that plp does not accept negative values for color.

If you change color=-ll-4 to color=ll+4 everywhere, it works fine, but I am not sure what the unintended consequences are.

Marcos

On 29/12/17 00:11, Francois Rigaut wrote:

Hi Ulas,

What version of yorick and of yao are you running? Thanks, Francois

On 28 Dec 2017, at 7:07 pm, UlasGokay notifications@github.com wrote:

Dear all, i am running the script file "yao_loop_example.i" for trying gsmag and gainv for a SH WFS, i am receiving an error: "(pl_get_color) LHS of assignment not an l-value (scalar double, long, int?)" which directs me to LINE: 1240 FILE: /usr/lib/yorick/i/plot.i but i couldn't solve the problem, i am guessing this is an issue related to this part of the code: "plg,strehlarray(ll,),gainv,color=-ll-4;", can you help? Best regards Ulas

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/frigaut/yao/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlb4q9w1nB6MdUMzzPrRjiYMwd4odiGks5tE0xRgaJpZM4ROGlj.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/frigaut/yao/issues/13#issuecomment-354272281, or mute the thread https://github.com/notifications/unsubscribe-auth/AAl_n2dBd919_2fEF89yTDpcPpU-b79rks5tE3degaJpZM4ROGlj.

-- Marcos van Dam Adaptive Optics Scientist Flat Wavefronts Postal Address: 21 Lascelles Street, Christchurch 8022, New Zealand Cell phone: +64 21 148 1956 Skype: marcos.van.dam Website: www.flatwavefronts.com

UlasGokay commented 6 years ago

Hi Marcos!

i see that the code runs when changed to ll+4, however this leads to single color (black) for all gsmags,

thank you!

Ulas