friggog / tree-gen

Procedural generation of tree models in blender
GNU General Public License v3.0
827 stars 74 forks source link

Allow creation of custom trees through UI (WIP) #10

Closed samipfjo closed 5 years ago

samipfjo commented 6 years ago

I have all the custom options displaying fairly decently in my parameter-customizer branch. Still need to implement loading the parameters before generation, but the inputs are present and they're locked to the ranges specified in the paper. I'm also planning on allowing users to save the parameters to a file (ala the existing format).

In other words, I'm back working on the project, now in a timezone even further from you than before (PDT/PST)! I have a full-time job, so my contributions may be more sporadic than before, but I'll be around.

image

friggog commented 6 years ago

Awesome news - and the progress is looking great. I'm also working full time now and quite busy with other things, but glad to see this project is still alive 😃. Keep me updated!

samipfjo commented 5 years ago

Customized generation is now fully working.*

I've added the ability to save the current settings to a file. Upon save, the tree choice drop-down is repopulated and the saved tree can be selected.

*Parameters that are lists (base_size, angles, etc.) have yet to be implemented. There's a clear way to do it, I just haven't gotten around to it yet.

Wound up having to merge the performance-enhancements branch into parameter-customizer. There was a super weird bug that kept causing generation to fail and I couldn't track down it down. I inadvertently fixed it in performance-enhancements, so in order to keep working I was forced to merge it in.

friggog commented 5 years ago

Awesome, I like to think our trees are nicer than those generated by some of the popular plugins (e.g. sapling) and with your work it's now comparatively fast. Once the UI is completely finished we should definitely post on some forums about it and try and get some more people about using the plugin!

samipfjo commented 5 years ago

I haven't spent a ton of time with other popular generators, but if I recall correctly I found sapling frustrating to use. SpeedTree is amazing, but it's a commerical product and also not a Blender addon, so that's not really a fair comparison :P

I agree wholeheartedly with posting once the UI is done. We're going to have a lot of PRs and issues to handle if the plugin gains traction, which could get interesting time-wise. But hey, can't really complain if it means people are using it!

friggog commented 5 years ago

Yeah SpeedTree is far above everything else, but so is the price! I'd really love to see people using our trees in animations etc. even if it does mean more work ;)

I should have a bit more free time for the next few months too so can probably pick up a bit more of the work - might have to brush up on my python though...

samipfjo commented 5 years ago

Animations would be a hell of a lot of work, as users will desperately want to have to automated bone generation. Sapling does it, so we could reference its implementation, but still...

samipfjo commented 5 years ago

See PR #16

friggog commented 5 years ago

Not sure if I'm being stupid but I just cloned the branch from https://github.com/friggog/tree-gen/pull/16 and I'm not seeing the parameter customisation UI - only the original UI. I can't see why this would happen other than me doing something stupid, and I'm pretty tired... Let me know if blender has any weird behaviour about reloading plugins or something - I'll try and get it working to properly test in the next few days.

samipfjo commented 5 years ago

You should be able to just exit blender -> delete the old folder -> copy the new one -> start blender

friggog commented 5 years ago

That's what I thought... I'll try again tomorrow

samipfjo commented 5 years ago

No worries; get some sleep :)

arpu commented 5 years ago

i had the same problem :> you need select custom as tree variant -> than the gui changes

samipfjo commented 5 years ago

Beat me to it. Was about to post the same message.

On Tue, Dec 11, 2018, 3:08 PM arpu <notifications@github.com wrote:

i had the same problem :> you need select custom as tree variant -> than the gui changes

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/friggog/tree-gen/issues/10#issuecomment-446397781, or mute the thread https://github.com/notifications/unsubscribe-auth/AGBgD5G0H4NqLP6Gp31QmPHdGCGnCUXHks5u4Dr_gaJpZM4XBQZA .

friggog commented 5 years ago

Was just me being an idiot then... I feel like armatures may not be too hard as the way stuff is generated lends itself relatively well to it. The original paper also has some comments on animation by armature-type methods which could help. I'll think about it... have created https://github.com/friggog/tree-gen/issues/19 to keep track of any discussions