samipfjo
commented
5 years ago Quaking Aspen with leaves (seed 100):
Before: Stems made: 1131 in 2.632385 seconds Made 31002 leaves and 0 blossoms in 5.648526 seconds Tree generated in 8.346872 seconds
After: Stems made: 1188 in 2.405932 seconds Made 30391 leaves and 0 blossoms in 2.056793 seconds Tree generated in 4.538678 seconds
Douglas Fir with leaves (seed 100):
Before: Stems made: 5782 in 24.919251 seconds Made 354022 leaves and 0 blossoms in 55.897657 seconds Tree generated in 81.486497 seconds
After: Stems made: 6151 in 19.982167 seconds Made 351227 leaves and 0 blossoms in 15.782944 seconds Tree generated in 36.447690 seconds
Weeping Willow with leaves (seed 100):
Before: Stems made: 30326 in 94.704319 seconds Made 388967 leaves and 0 blossoms in 65.510431 seconds Tree generated in 161.144178 seconds
After: Stems made: 39770 in 124.523556 seconds Made 483994 leaves and 0 blossoms in 24.791790 seconds Tree generated in 150.350708 seconds
Summary
Stems: There appears to be a performance increase in stem generation in the Douglas Fir comparison, and a slight performance increase in the Quaking Aspen comparison. Running the numbers on the Weeping Willow comparison, however, results in an inconclusive race.
Leaves: Leaf generation is unquestionably faster. I'm so glad that deepcopy() isn't needed anymore.
Testbench specs:
Acer Aspire v3-771G (laptop) 2.4GHz Quad-Core i7-3630QM | 12GB DDR3 1600 MHz | SATA3 SSD
friggog
This PR contains a slew of performance improvements, both small and large.
The largest improvement included is the replacement of deepcopy() with a simple list comprehension, which dramatically speeds up leaf generation.
Other changes include:
Moving stdout handling to a separate thread (the overhead for printing that frequently turned out to be bananas)
Replacing a couple of the manual implementations of random number generation with faster built-ins (I ran a bunch of rounds of timeit to make sure they were improvements).
Addition of .idea/ to the .gitignore (the folder that PyCharm uses to store its project config)
Some general format cleanup; adding whitespace between code blocks and such. Not a meticulous overhaul by any means.