friggog / tree-gen

Procedural generation of tree models in blender
GNU General Public License v3.0
827 stars 74 forks source link

Separate branch curves and remove branch LOD creation #60

Closed samipfjo closed 3 years ago

samipfjo commented 3 years ago

Implement #49

Instead of having one big curve, instead separate the curves by depth ("level"), such that a tree with 3 levels will have 3 curves: Trunk, Branches1, Branches2.

This PR also removes branch LOD creation. Leaf LOD creation has been preserved. This is out-of-scope for the topic, but it's something we've talked about in the past; it would have been a bit more work to implement it so I decided it was a good time to remove it.

friggog commented 3 years ago

This creates separate curves, and then meshes, for each branch level right? Not sure if we want to merge the mesh and have levels as separate vertex groups or keep them distinct? single mesh seems neater but not sure if there is practically much difference

samipfjo commented 3 years ago

Yeah, separate curves and subsequently separate meshes right now. I can certainly look into making them separate vertex groups instead if you think that's preferable.

friggog commented 3 years ago

Yeah, separate curves and subsequently separate meshes right now. I can certainly look into making them separate vertex groups instead if you think that's preferable.

Let's leave it as is for now

samipfjo commented 3 years ago

Should be ready for merge unless there's something else I missed. I took care of the straggler TODOs, at least.