friguzzi / cplint

cplint is a suite of programs for reasoning with probabilistic logic programs
Other
67 stars 14 forks source link

Wrong erase/1 #38

Closed JanWielemaker closed 4 years ago

JanWielemaker commented 4 years ago

https://github.com/friguzzi/cplint/blob/83f1d0ca645af85ef88eb12f58a3baa1478556b1/prolog/mcintyre.pl#L307

This is surely not good, but not used in the tests. erase/1 takes a db ref. I think what is meant is

save_samples(M,G):-
  forall(retract(M:sampled(R,Sub,V),
         assertz(M:mem(G,R,Sub,V)))).
friguzzi commented 4 years ago

Thanks, fixed in 8fea36b