search

friimaind / pi-hole-droid

Pi-hole Droid is an unofficial app that connects to your Pi-hole to show charts and statistics.
Apache License 2.0
125 stars 16 forks source link

Attempt to resolve version number not being detected by FDroid #26

Closed m00head closed 4 years ago

m00head commented 4 years ago

@Rudloff @Izzysoft One or more of the 3 changed files below may fix the following issue: https://github.com/friimaind/pi-hole-droid/issues/20#issuecomment-545146551

m00head commented 4 years ago

@Rudloff Will this file also need to be updated with the correct version number? https://gitlab.com/Rudloff/fdroiddata/blob/develop/metadata/friimaind.piholedroid.yml

IzzySoft commented 4 years ago

Yes, that should help. Especially making it literal in the gradle.

Rudloff commented 4 years ago

I you tag your versions correctly, friimaind.piholedroid.yml should be updated automatically.

m00head commented 4 years ago

@friimaind Please will you review this change, and merge it if you happy with it?

m00head commented 4 years ago

I have created a merge request on the FDroid GitLab site to use the latest version tag: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6786

m00head commented 4 years ago

@friimaind Please will you tag the latest commit on master (https://github.com/friimaind/pi-hole-droid/commit/fd06eda5b96de9dec078c15ad90143df8f770223) as v1.0.5 (not 1.0.5 with missing v prefix) to so that FDroid will detect the correct version number: https://github.com/friimaind/pi-hole-droid/tags

friimaind commented 4 years ago

@m00head done!