fringd / zipline

A gem that lets you stream a zip file from rails
MIT License
289 stars 68 forks source link

Stops classes from loading for engine... #107

Closed ConfusedVorlon closed 2 months ago

ConfusedVorlon commented 2 months ago

this is wierd, and I don't really understand what's going on. I'm using JumpstartPro that contains an engine with an initializer

module Jumpstart
  class Engine < ::Rails::Engine
    isolate_namespace Jumpstart
    engine_name "jumpstart"

    #snip

    initializer "turbo.native.navigation.helper" do
      ActiveSupport.on_load(:action_controller_base) do
        include Turbo::Native::Navigation
        helper Rails.application.helpers
      end
    end

    #snip
  end
end

If I have zipline installed, then the line helper Rails.application.helpers fails because classes haven't been loaded yet. Without zipline - then classes are already loaded at this point. Oddly - I'm not the first person to hit this bug. The healthcheck gem also triggers this failure mode.

Honestly - I don't know whether this is zipline doing something wrong, or jumpstart. Posting here in the hope that it triggers an idea...

ConfusedVorlon commented 2 months ago

closing this - it seems Jumpstart can fix the issue...