search

fringd / zipline

A gem that lets you stream a zip file from rails
MIT License
289 stars 68 forks source link

Loosen zip_tricks dependency #55

Closed aried3r closed 4 years ago

aried3r commented 4 years ago

Is there any way we can remove the upper bounds altogether to reduce maintenance burden? Big gems like devise also did this, as did paper_trail, however a bit more conservatively, using a warning.

https://github.com/heartcombo/devise/commit/54fb58226976984bf7b322a2136d25921093fa85 https://github.com/paper-trail-gem/paper_trail/commit/a107146dedc6e1af8c5cf226a44c1adc3b223c0a

Edit: https://github.com/WeTransfer/zip_tricks/blob/master/CHANGELOG.md

fringd commented 4 years ago

So... I wanted to keep zipline on 4.x because I thought it would be a bit weird for me to be on MIT but have hippocratic license dependencies. I seem to have failed at that since i'm <= 5.0.0 instead of < 5.0.0 so... 🤷‍♂️

I dunno. I'm not sure what to do now? What are your thoughts on transitive dependencies with more restrictive licenses? Is there something you need from the new zip tricks?

fringd commented 4 years ago

I mean I guess I could just loosen the dependencies and people can choose a specific version depending on the license that works for them?

aried3r commented 4 years ago

That sounds like an acceptable solution!

aried3r commented 4 years ago

Is there something you need from the new zip tricks?

Late reply. Not so much anything they added, but actually that they restricted rubyzip versions, because I also hit this bug https://github.com/WeTransfer/zip_tricks/issues/65.

Nothing I cannot do myself in my own Gemfile, but I'd rather not.

aried3r commented 4 years ago

Hey @fringd, any chance of a release with this change? Or do you want to loosen this dependency even more?

fringd commented 4 years ago

published 1.2.0 for you