search

fringd / zipline

A gem that lets you stream a zip file from rails
MIT License
288 stars 68 forks source link

swap dependency: rails -> actionpack, relax version restriction on actionpack (allowing Rails 6.1) #69

Closed swiknaba closed 3 years ago

swiknaba commented 3 years ago

Thanks for the gem!

After reading issue https://github.com/fringd/zipline/issues/68 (add support for Rails 6.1), I've browsed through the code, and I think we don't even need the entire Rails gem here, but only actionpack to handle the request/response that this gem aims to hook into.

Since there haven't been any changes to ActionPack that should break anything of this gem (I think! :D), we can relax requirements to < 7.0.

I've sorted the dependencies in alphabetical order (default rubocop suggestion) --feel free to sort this back if you mind.

closes https://github.com/fringd/zipline/issues/68

navied commented 3 years ago

@fringd would it be possible to get a new gem release with these changes?

Thanks!