Fix call to ZipTricks::Streamer#write_deflated_file to match method signature

fringd / zipline

A gem that lets you stream a zip file from rails

MIT License

289 stars 68 forks source link

Fix call to ZipTricks::Streamer#write_deflated_file to match method signature #76

Closed leboshi closed 3 years ago

leboshi commented 3 years ago

Fixes #75.

The previous implementation took advantage of kwarg/hash interoperability in method calls that was deprecated in Ruby 2.7.2 and dropped in Ruby 3.

leboshi commented 3 years ago

(Granted, we didn't really read around to see whether there were any other places this needed to happen; this is just the invocation we happened to find because we use it. 😛)

aried3r commented 3 years ago

Friendly ping, @fringd. Would really help us with moving to Ruby 3 if this made it to an official release. :)

gingerlime commented 3 years ago

Also bumped into it after upgrading to ruby 3. Was this fix released? I think we're using the latest version of Zipline and still see this error unfortunately.

fringd commented 2 years ago

sorry I'll push a release now.