search

frintjs / frint-props

Compose reactive props in FrintJS applications
https://frint.js.org
MIT License
12 stars 1 forks source link

isObservable package is not being transpiled #30

Closed leandrooriente closed 6 years ago

leandrooriente commented 6 years ago

For some reason, the isObservable package is not transpiled on production builds. https://github.com/sindresorhus/is-observable/blob/master/index.js (published without transpilation)

Search for: value => Boolean(value && value[symbolObservable] && value === value[symbolObservable]()); on https://test-frint-props-standalone-acceptance.cheaptickets.nl/assets/js/fireball/vendors.js?bb7e85ac72948ea092eacee7bd1027c70dbe0bfd

It breaks IE because it doesn't support arrow functions.

leandrooriente commented 6 years ago

The maintainers from is-observable don't want to transpile the code or add supports to Browsers. https://github.com/sindresorhus/is-observable/issues/8

And I don't think that check every package on RWD node_modules is a good idea for us.

leandrooriente commented 6 years ago

We decided to fix it on our webpack config.

We add only is-observable to the build process. 

exclude: (modulePath) => (
  /node_modules/.test(modulePath) &&
  !/node_modules\/is-observable/.test(modulePath)
)