frinyvonnick / gitmoji-changelog

A changelog generator for gitmoji 😜
https://www.npmjs.com/package/gitmoji-changelog
MIT License
390 stars 49 forks source link

No change found error get catched by error reporter #170

Closed bpetetot closed 4 years ago

bpetetot commented 4 years ago

Stacktrace

Error: awesomeversion is not a valid semver version.
    at getChangelog (/Users/ben/Developer/gitmoji-changelog/packages/gitmoji-changelog-cli/src/cli.js:138:11)

Environment

System:

CLI options

Project info


This error report was generated with ❤️ by issue-reporter

bpetetot commented 4 years ago

The end 2 end test is not enough precise:

it('shouldn\'t generate changelog when gimoji-changelog if there isn\'t any changes', async () => {
      await makeChanges('file1')
      await commit(':sparkles: Add some file')
      await bumpVersion('1.0.0')
      gitmojiChangelog()
      await commit(':bookmark: Version 1.0.0')
      await tag('1.0.0')
      const output = gitmojiChangelog()

      expect(getChangelog()).includes(['1.0.0'])
      expect(output.toString('utf8')).toDisplayError()
    })
frinyvonnick commented 4 years ago

This is not the only functional error catched. Closed in favor of #176