This PR fixes issue #231. Node 14 doesn't seem to accept undefined as data arg to fs.writeFileSync(), so let's just pass an empty string.
Moreover, the last E2E test ("generate changelog > update > should display an error if requested version isn't semver") expects an error to be logged when passed a non-semver release option. However the CLI throws a generic Error in these cases, which are eventually intercepted by the issue reporter instead of being logged:
This PR fixes issue #231. Node 14 doesn't seem to accept
undefined
asdata
arg tofs.writeFileSync()
, so let's just pass an empty string.Moreover, the last E2E test ("generate changelog > update > should display an error if requested version isn't semver") expects an error to be logged when passed a non-semver
release
option. However the CLI throws a genericError
in these cases, which are eventually intercepted by the issue reporter instead of being logged:https://github.com/fredericbonnet/gitmoji-changelog/blob/4a293caece43a953940ed7d753387c41f5df33ab/packages/gitmoji-changelog-cli/src/cli.js#L105-L128
I don't think that's the intended behavior, so the fix is to throw a
FunctionalError
instead.Happy Hacktoberfest! 🎃