schema_version supports defination via version module

frioux / DBIx-Class-DeploymentHandler

https://metacpan.org/pod/DBIx::Class::DeploymentHandler

20 stars 25 forks source link

schema_version supports defination via version module #48

Closed p-alik closed 7 years ago

p-alik commented 7 years ago

I trapped into exception:

Attribute (schema_version) does not pass the type constraint because: Schema version (currently 'v0.11') must be a string at reader DBIx::Class::DeploymentHandler::Dad::schema_version (defined at ../DBIx-Class-DeploymentHandler/lib/DBIx/Class/DeploymentHandler/Dad.pm line 30

because I used version modul for schema version definition. Therefore I slightly modified your implementation and I hope it could be useful for the other perl geeks.

coveralls commented 7 years ago

Coverage increased (+0.3%) to 92.561% when pulling c2067765919b977fae6efc3f3e4db30435fb6e9f on p-alik:master into c9528ca942027a1beb2ff99a12c46ebb86443674 on frioux:master.

p-alik commented 7 years ago

It looks like my PR doesn't meet your approach By default DBIx::Class::DeploymentHandler only uses integers for versions

however if you think it could be useful I'll spend more time because in this state it doesn't work