search

frioux / DBIx-Class-DeploymentHandler

https://metacpan.org/pod/DBIx::Class::DeploymentHandler
21 stars 26 forks source link

Use producer_args for SQL::Translator::Diff->new #58

Closed mmcclimon closed 7 years ago

mmcclimon commented 7 years ago

Since these args are intended to be passed to the SQL::Translator inside of SQL::Translotor::Diff, they need to be passed as producer_args instead of raw hash keys.

I discovered this while rjbs and I were trying to track down a bug with column names that weren't being quoted properly in the Postgres producer (but only in the generated SQL in upgrade/, not in deploy/). That problem turned out to be a bug in SQL::Translator::Producer::PostgreSQL, but nonetheless uncovered this bug in DBIC::DH!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.062% when pulling b2337c2d6d2c86202d9fe77aee3adcd971aa4047 on mmcclimon:sqlt-diff-args into 0c28f0112d95b193c8da3c4524917282d16982ca on frioux:master.

mmcclimon commented 7 years ago

Released in v0.002221 (b3634675).