search

frioux / DBIx-Class-DeploymentHandler

https://metacpan.org/pod/DBIx::Class::DeploymentHandler
21 stars 26 forks source link

Sql splitstatement #74

Closed augensalat closed 5 years ago

augensalat commented 5 years ago

Summary

Implement a more robust SQL splitter upon SQL::SplitStatement

Do not remove "false" transactions

Do not create DDLs with surrounding BEGIN/COMMIT just to remove anything that seems to be a transaction later in the deployment phase (which currently reliably fails with PROCEDUREs, TRIGGERs and everything else that uses the BEGIN keyword).

This feature is off by default to keep backwards-compatibility.

References

Fixes

47

68

72

... and probably a few more

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.08%) to 89.969% when pulling 96efc2b77a68d2871cfe0d349e1efc9b8961832f on augensalat:sql-splitstatement into c14c092dec4728eb6d5278d90cf5820c490dfe5e on frioux:master.

mmcclimon commented 5 years ago

Hi, thanks! I'll have a look at this soon: hopefully within the next ten days. I will definitely be happy to make this behavior more consistent and reliable, since as you noted, there's a bunch of reports about it!

augensalat commented 5 years ago

Hi, thanks! I'll have a look at this soon: hopefully within the next ten days. I will definitely be happy to make this behavior more consistent and reliable, since as you noted, there's a bunch of reports about it!

Reminder!