search

frioux / DBIx-Class-Helpers

https://metacpan.org/pod/DBIx::Class::Helpers
20 stars 38 forks source link

enable tests against SQLite on travis #82

Closed simbabque closed 4 years ago

simbabque commented 7 years ago

Commit 123fa4a165834901fcef56faa111fe7fc5ce7741 has disabled the possiblity to pass in a connect_info when the creation of that property was moved from the default handler into A::Util along with the call to it in connect(), which was also moved to A::Util. When connect_info is passed to the test object it is now never used, because it does not get handed on to the A::Util::connect call that happens in the builder for schema.

It would be nicer to have the tests default to SQLite without needing an environment variable, but the current architecture in A::Util makes that tricky without changing too much. This change removes unused code and leaves the current behavior untouched.

I found this when looking at the coverage report, specifically the yellow file Explain.pm. A further look at travis revealed that the tests using sqlite in ::Explain never get executed.

This is my entry for the Pull Request Challenge 2017 in May.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 98.638% when pulling cede81d36a4b615dddad988552fdebfd90866594 on simbabque:sqlite-tests into 1445098fca40f725352ff401ae657a2c58e05563 on frioux:master.

ribasushi commented 4 years ago

@rabbiveesh does https://github.com/frioux/DBIx-Class-Helpers/pull/99/commits/9bb188f81cab025e818e57a0b637385b021ed00d make this PR no longer needed?

rabbiveesh commented 4 years ago

@ribasushi indeed it does.

frioux commented 4 years ago

This has been replaced with #99; thanks!