search

frioux / DBIx-Class-Helpers

https://metacpan.org/pod/DBIx::Class::Helpers
20 stars 38 forks source link

Fix results_exist for good #98

Closed ribasushi closed 4 years ago

ribasushi commented 4 years ago

@frioux we got to fix this man... Folks are resorting to primitivisms like this, because the thing in Helpers doesn't work for them.

This PR takes my suggestions https://github.com/frioux/DBIx-Class-Helpers/commit/85702318c13da517d0c9d6b997ff346fdc47abba#commitcomment-25738859 and https://github.com/frioux/DBIx-Class-Helpers/commit/85702318c13da517d0c9d6b997ff346fdc47abba#commitcomment-26140541 and combines them with some docs.

This is what I've been using at work for close to 3 years now, it should work across all DBs unmodified.

Obsoletes/addresses:

Cheers

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.004%) to 98.732% when pulling d54fed5718bd2e894b37265e97aeb2ddf2194ed1 on ribasushi:final_results_exist into 661b3d3c8985c4d8eb4a1e7a4d608f1d04d03303 on frioux:master.

frioux commented 4 years ago

Merged, releasing shortly

ribasushi commented 4 years ago

@frioux thank you!

@tcorkran: it is done.