search

frioux / Win32-ServiceManager

https://metacpan.org/pod/Win32::ServiceManager
5 stars 3 forks source link

Remove the 'args' argument in service installation #4

Closed TeoBotta90 closed 4 years ago

TeoBotta90 commented 4 years ago

Drop the 'args' option since it doesn't work. Review the syntax for sc command, Let the user configure the full binpath string in the "command" argument.

wesQ3 commented 4 years ago

Hi, thanks for the patch.

We prefer descriptive commit messages in this project to make the project history easier to search in the future. Could you revise your commits to describe the changes in each with a short message (like the description in your pull request)?

TeoBotta90 commented 4 years ago

Hi, thanks for the patch.

We prefer descriptive commit messages in this project to make the project history easier to search in the future. Could you revise your commits to describe the changes in each with a short message (like the description in your pull request)?

Of couse @wesQ3, you see no description in the commits because I'm new to GitHub. I'll try to fix them asap

TeoBotta90 commented 4 years ago

Hi, thanks for the patch.

We prefer descriptive commit messages in this project to make the project history easier to search in the future. Could you revise your commits to describe the changes in each with a short message (like the description in your pull request)?

Please be patient, I've put some comments on each piece of code that I've modified. Is it ok? Otherwise, please explain what should I do. Thanks!

wesQ3 commented 4 years ago

I can see you're new. That's okay, everyone has to start somewhere and I'm glad you want to help :)

Those are review comments which you've made on this pull request; I was referring to the commit messages on the commits themselves. Take a look at the master branch on your fork of the repo, see how the previous commits have messages describing what was changed? When you make a commit your git client will prompt you to add a message to describe the change you made.

Do you have a git client to revise your commits?

TeoBotta90 commented 4 years ago

Hi, thanks for your help. I'll download a client that allows me to revise my commits

Il giorno mar 19 nov 2019 alle ore 21:30 Wes Malone < notifications@github.com> ha scritto:

I can see you're new. That's okay, everyone has to start somewhere and I'm glad you want to help :)

Those are review comments which you've made on this pull request; I was referring to the commit messages on the commits themselves. Take a look at the master branch on your fork https://github.com/TeoBotta90/Win32-ServiceManager/commits/master of the repo, see how the previous commits have messages describing what was changed? When you make a commit your git client will prompt you to add a message to describe the change you made.

Do you have a git client to revise your commits?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/frioux/Win32-ServiceManager/pull/4?email_source=notifications&email_token=ANZU6DWDIYYQOT5MWI3M5BLQUREF7A5CNFSM4JOVDSEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEPUVTQ#issuecomment-555698894, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANZU6DS7Z62ALII3ZRLM3ZTQUREF7ANCNFSM4JOVDSEA .

TeoBotta90 commented 4 years ago

Hi, I've downloaded this one https://www.gitkraken.com/git-client I'd like to fix all the remaining issues in this fork, are you available for a quick WebEx? If so, please tell me when you're available and I'll arrange it.

Thanks, best regards

Il giorno mar 19 nov 2019 alle ore 21:30 Wes Malone < notifications@github.com> ha scritto:

I can see you're new. That's okay, everyone has to start somewhere and I'm glad you want to help :)

Those are review comments which you've made on this pull request; I was referring to the commit messages on the commits themselves. Take a look at the master branch on your fork https://github.com/TeoBotta90/Win32-ServiceManager/commits/master of the repo, see how the previous commits have messages describing what was changed? When you make a commit your git client will prompt you to add a message to describe the change you made.

Do you have a git client to revise your commits?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/frioux/Win32-ServiceManager/pull/4?email_source=notifications&email_token=ANZU6DWDIYYQOT5MWI3M5BLQUREF7A5CNFSM4JOVDSEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEPUVTQ#issuecomment-555698894, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANZU6DS7Z62ALII3ZRLM3ZTQUREF7ANCNFSM4JOVDSEA .