search

frisciliasultan / pe

0 stars 0 forks source link

Commands should be in small caps #4

Open frisciliasultan opened 3 years ago

frisciliasultan commented 3 years ago

Commands like deleteTag, findTag should be small letter to improve the experience of fast typists.

nus-pe-bot commented 3 years ago

Team's Response

Thank you for your report. We deliberately chose to name deleteTag and findTag in this manner to emphasise that their functionality is similar to the basic delete and find commands except that these two special commands work on the Tag class rather than the actual task.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The argument does not answer the question. Firstly, changing deleteTag to deletetag would not dilute the similarity to delete. Secondly, a user would not be concerned of which class it is working on, as long as it is working. Also, deletetag would still indicate that it works on Tag class. This is a cosmetic bug where it is slightly more inconvenient for the user to press the shift key in the middle of typing. Since it only causes very minor inconvenience, I labelled the bug as VeryLow