frisen-lab / TREX

Simultaneous lineage TRacking and EXpression profiling of single cells using RNA-seq
MIT License
6 stars 6 forks source link

Usage of the smartseq vs. 10x runs commands unclear #8

Closed Leonievb closed 1 year ago

Leonievb commented 2 years ago

The run10x positional argument allows running trex on 10x Chromium data which have UMIs. Smartseq2 data don't have UMIs and for this purpose the smartseq3 positional argument was added (the name of the argument is wrong and should be smartseq2). However, smartseq3 produces data with UMIs and there is currently no way to run trex on this. Therefore the following should be done:

marcelm commented 2 years ago

The main branch only has the run10x subcommand. Smart-Seq2 functionality is currently only in the (incorrectly named) smartseq3 branch. Should that branch be merged?

marcelm commented 2 years ago

I’ve taken the liberty of editing your original post so that the items it contains are formatted as a to-do list.

marcelm commented 2 years ago

I have renamed the smartseq3 branch to smartseq2 and also added a commit to the branch that changes the subcommand name to smartseq2.

marcelm commented 2 years ago

I’ve converted the third item to a separate issue.

Leonievb commented 2 years ago

It would make sense to merge the smartseq2 branch into the main branch to make it easily available

marcelm commented 2 years ago

Ok, I’ll send an e-mail to confirm with Michael.

marcelm commented 2 years ago

I have merged the branch now. I would usually open a PR for something like this, but there were some merge conflicts that were a bit tricky to fix, so I just did the merge "by hand".