Redesign Request Implementation

frissyn / valorant.py

Complete Python interface for the Valorant API. Works right out of the box!

https://valorantpy.readthedocs.io

MIT License

125 stars 19 forks source link

Redesign Request Implementation #24

Closed frissyn closed 2 years ago

frissyn commented 2 years ago

Current web and client request implementation was done hastily, definitely a good idea to refactor it before working on adding endpoint coverage for matches and users. Waiting on 0.5.0 milestone

[x] Create an abstract class for requests.
[x] Split classes for web requests and client requests.
[x] Make requester synergize with web, client, and local requests.

frissyn commented 2 years ago

Looks like I'm going for an abstracted solution pasted together with duct tape... definitely need to clean up the kinks in the caller classes before moving on to the Local Client. Current implementation completely separates the functions of the client and the HTTP requests to the API, which would be the smartest move before going on to covering match and local client endpoints.

Hopefully reworking the Async Client will go just as smoothly (not that this went smoothly but whatever)

frissyn commented 2 years ago

... just realized none of what I said makes any sense removed from the context of my mind. need to stop programming at 4am