frissyn / valorant.py

Complete Python interface for the Valorant API. Works right out of the box!
https://valorantpy.readthedocs.io
MIT License
125 stars 19 forks source link

Error running on macOS #46

Open LuiFerreiraD opened 1 year ago

LuiFerreiraD commented 1 year ago

Hi, I am trying to use the package, but unfortunately I am encountering an error when importing it. When calling the "from .lexicon import Lex", there's an error in the LOCALE setting. LOCALE = locale.getdefaultlocale()[0].replace("_", "-"), but my macOS returns (None, 'UTF8') to the "locale.getdefaultlocale()" call. The error is as follows: "AttributeError: 'NoneType' object has no attribute 'replace'" I see in the documentation of "Client" that it has the option to be None, so I think this was considered in the client.py but not on the lexicon.

The fix should be easy, it think: LOCALE = locale.getdefaultlocale()[0].replace("_", "-") if locale.getdefaultlocale()[0] else None

frissyn commented 1 year ago

@LuiFerreiraD I not 100% sure, but it might be an issue with not being able to access environment variables, or some other means of determining your system's locale. I'll add a check for this in the next day or so though, thanks for reporting!