Closed LucaFulchir closed 8 years ago
Thanks for the patch, I'll look into it!
I incorporated your patch into the init file, and I also added a service file for systemd (which I didn't test). Please re-merge version 8.0.5 and test! Thanks.
The default delivery method for mail_room is using sidekiq
, so for the "reply by email" function to work properly, we need to add incoming_email
to sidekiq_queues
.
I'm not really sure if it's ok to always add it regardless of whether mail_room
is starting... or it's better to configure it dynamically based on the current configuration?
You're right.
I added the queues "incoming_email" and "runner" to the init script for the existing 8.1.0 and 8.1.2 ebuilds, so please just re-merge one of those versions, and you should be good to go. The queues will be started regardless of whether mail_room is enabled or not, since it's also like this in the upstream init script.
mail_room is never started.
This is a proposed patch to test the existence of /etc/default/gitlab, and make sure that it contains "mail_room_enabled=true" just like the documentation says.