search

fritx / cross-unzip

Cross-platform 'native' unzip in Node.js
https://www.npmjs.com/package/cross-unzip
17 stars 4 forks source link

Breaks on non-Windows systems without `unzip` package installed #6

Open st-sloth opened 6 years ago

st-sloth commented 6 years ago

Code in this project relies on the notion that if the system is not Windows, then it has CLI command unzip available. However some systems, like Manjaro Linux, don't come with unzip already installed. So cross-unzip just fails with spawn unzip ENOENT.

fritx commented 6 years ago

@st-sloth my bad..

We could probably add more supports, like https://github.com/uiureo/node-screencapture/pull/7/files

st-sloth commented 6 years ago

Dunno, I don't think depending on external tools will ever be safe anyway. https://www.npmjs.com/package/extract-zip seem to manage with just JS.

fritx commented 6 years ago

@st-sloth yeah that would have both pros and cons.

I had been using tools implemented in pure JS before, but there would be problems like performance, so this library would be an alternative from them.