search

fritx / vue-at

At.js for Vue.
https://fritx.github.io/vue-at/
MIT License
530 stars 114 forks source link

Cannot resolve module 'vue-at' #1

Closed antongorodezkiy closed 7 years ago

antongorodezkiy commented 7 years ago

Hello @fritx

package.json is referencing dist/index.js - https://github.com/fritx/vue-at/blob/master/package.json#L11 but there is no dist directory in the package.

So when requiring it with require('vue-at') I got an error:

Cannot resolve module 'vue-at'

fritx commented 7 years ago

Oops! My bad.. I guess I mistakenly ignored dist/ in .npmignore. It's weird that I can't find it in the github repo now 😕 Let me republish it.

fritx commented 7 years ago

Even though I republished vue-at@2.0.1 based on files of this repo, it's terrible there is still an npmignore and no dist/ in the package.

antongorodezkiy commented 7 years ago

Could the issue be in https://github.com/fritx/vue-at/blob/master/.gitignore#L3 ?

fritx commented 7 years ago

@antongorodezkiy yeah, thank ya so much for reporting this. :+1: I guess I've figured out what was going on...

If npmignore is missing, it occurs same as gitignore in the package. I didn't check it by npm pack before npm publish -- my bad.

Once if I put my npmignore (without dist/), it will be the one in the package. I now highly doubt Is it a new bug or behavior of npm?

2.0.2 is out now with the fix.

antongorodezkiy commented 7 years ago

I now highly doubt Is it a new bug or behavior of npm?

Unfortunately I don't know.

2.0.2 is out now with the fix.

Seems to be fixed, thank you!